Ticket #77 (closed enhancement: fixed)

Opened 9 months ago

Last modified 9 months ago

please remove "require 'rubygems'" statements in tests

Reported by: http://boutil.myopenid.com/ Owned by: deveiant
Milestone: Bugfixes Component: Packaging
Version: 2.1.0 Severity: normal
Keywords: rubygems spec Cc: cedric.boutillier@…

Description

I can see that in three of the spec files, {contributions_spec.rb, discount_spec.rb, matchers.rb}, there is a require 'rubygems' statement. This can be a problem because this statement fails if the user doesn't have rubygems installed and it causes manually-installed (or installed with a package manager) libraries to be ignored after rubygems has been loaded.

See ​http://wiki.debian.org/Teams/Ruby/RubyExtras/UpstreamDevelopers, section "Remove all references to rubygems in the software you ship", for more information.

Could you please remove these statements, or make them conditional on a global variable, as presented in the above document, if you need them for development?

Thanks!

Change History

comment:1 Changed 9 months ago by deveiant

  • Status changed from new to assigned

Will do.

comment:2 Changed 9 months ago by Michael Granger <ged@…>

In [c9ade2a25f8f1bccaf568ce937f0b6ee461008f5]:

Removing 'rubygems' require from specs. Fixes #77.

comment:3 Changed 9 months ago by deveiant

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.